Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalise TypeScript Migration #2206

Open
faustbrian opened this Issue Mar 6, 2019 · 0 comments

Comments

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Mar 6, 2019

  • Replace all occurrences of any with a proper type
  • Replace all occurrences of types like Record<string, any> with types that are self-explanatory so they are less generic and don't need to be accompanied by comments
  • Remove all occurrences of @ts-ignore
  • Reduce all variables that have multiple types to a single type
  • Move all types of a package into a src/types.ts file. Don't export types from random files!
  • Move all interfaces of a package into a src/interfaces.ts file if they are not used by other packages. If they are used by other packages move them into @arkecosystem/core-interfaces. Don't export interfaces from random files!
  • Clean up some messy code that is still left over from the JavaScript days so it doesn't need to be accompanied by comments

If any types from a third-party package are wrong or missing, fix or add them and submit a PR to https://github.com/DefinitelyTyped/DefinitelyTyped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.