Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom (storage) implementations for core-transaction-pool #2451

Open
faustbrian opened this issue Apr 20, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@faustbrian
Copy link
Collaborator

commented Apr 20, 2019

At the moment the core-transaction-pool package has quite a few things hard-coded that should be replaceable if a user wants to do so without having to do a full copy of the package or run a modified version of it.

I for example run my own transaction pool package that doesn't have an on-disk storage and quite a few other modifications which requires me to to stay in sync with every change to core-transaction-pool because it contains a lot of business logic that should only rely on data it gets fed from the concrete storage implementation. So instead of being able to simply swap out the storage or modify a tiny chunk of logic I end up having to maintain a full copy of the package.

The situation is basically the same as core-database and core-database-postgres where core-database-postgres used to contain a lot of logic that belongs to core-database because it just relies on data it is fed from the database. core-database-postgres doesn't need to know what happens with the data it pulls from the database, it just needs to pass it to core-database so it can process it.

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

What a good idea!

@faustbrian

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 23, 2019

Part of this will be the introduction of a TransactionPool.IService similar to how core-p2p does it.

Instead of passing around a dozen instances like at https://github.com/ArkEcosystem/core/blob/develop/packages/core-transactions/src/handlers/transaction.ts#L126-L130 we will pass in an instance of TransactionPool.IService which will expose methods like service.getConnection() and service.getStorage().

@faustbrian faustbrian added this to the 3.0.0 milestone May 3, 2019

@faustbrian faustbrian self-assigned this May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.