Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: crypto package cannot handle vendorfield > 255 #3697

Closed
ItsANameToo opened this issue May 12, 2020 · 1 comment
Closed

bug: crypto package cannot handle vendorfield > 255 #3697

ItsANameToo opened this issue May 12, 2020 · 1 comment
Assignees

Comments

@ItsANameToo
Copy link
Member

the crypto SDK reads uint8 for vendorfield length, so it's capped at 256 max and causes issues when you deploy a chain that sets a larger vendorfield limit

Expected Behavior

should handle larger vendorfields too

Current Behavior

it doesn't

Possible Solution

change uin8 to uin16 for a larger range

Steps to Reproduce (for bugs)

  1. set up a chain with a larger vendorfield (e.g. 1024)
  2. set up the sdk to use that network
  3. try to send a tx with > 256 bytes vendorfield
  4. run into ser/der issues

Context

Your Environment

  • latest everything
@air1one
Copy link
Contributor

air1one commented Jul 1, 2020

We just won't allow vendorField > 255 bytes, IPFS and custom transactions are here in case anyone wants to store more data 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants