New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: core-debugger-cli #1048

Merged
merged 8 commits into from Oct 2, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Oct 2, 2018

Proposed changes

Testing is currently quite annoying when something with blocks or transactions blows up and you want to see what is behind the hex string. This adds some basic cli to perform serialise, deserialise and verify. Will add more commands after this PR is merged.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@faustbrian faustbrian requested review from supaiku0 and alexbarnsley Oct 2, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 2, 2018

Codecov Report

Merging #1048 into develop will decrease coverage by 0.32%.
The diff coverage is 3.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1048      +/-   ##
==========================================
- Coverage    72.82%   72.5%   -0.33%     
==========================================
  Files          412     417       +5     
  Lines         6774    6804      +30     
  Branches       859     863       +4     
==========================================
  Hits          4933    4933              
- Misses        1643    1670      +27     
- Partials       198     201       +3
Impacted Files Coverage Δ
...s/core-debugger-cli/lib/utils/copy-to-clipboard.js 0% <0%> (ø)
...ckages/core-debugger-cli/lib/commands/serialize.js 0% <0%> (ø)
packages/core-debugger-cli/lib/commands/verify.js 0% <0%> (ø)
...kages/core-debugger-cli/lib/utils/handle-output.js 0% <0%> (ø)
...ages/core-debugger-cli/lib/commands/deserialize.js 0% <0%> (ø)
packages/crypto/lib/models/block.js 72.48% <50%> (-0.2%) ⬇️
packages/core-p2p/lib/utils/check-ntp.js 92.85% <0%> (-7.15%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa695c...7867cba. Read the comment docs.

codecov-io commented Oct 2, 2018

Codecov Report

Merging #1048 into develop will decrease coverage by 0.32%.
The diff coverage is 3.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1048      +/-   ##
==========================================
- Coverage    72.82%   72.5%   -0.33%     
==========================================
  Files          412     417       +5     
  Lines         6774    6804      +30     
  Branches       859     863       +4     
==========================================
  Hits          4933    4933              
- Misses        1643    1670      +27     
- Partials       198     201       +3
Impacted Files Coverage Δ
...s/core-debugger-cli/lib/utils/copy-to-clipboard.js 0% <0%> (ø)
...ckages/core-debugger-cli/lib/commands/serialize.js 0% <0%> (ø)
packages/core-debugger-cli/lib/commands/verify.js 0% <0%> (ø)
...kages/core-debugger-cli/lib/utils/handle-output.js 0% <0%> (ø)
...ages/core-debugger-cli/lib/commands/deserialize.js 0% <0%> (ø)
packages/crypto/lib/models/block.js 72.48% <50%> (-0.2%) ⬇️
packages/core-p2p/lib/utils/check-ntp.js 92.85% <0%> (-7.15%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa695c...7867cba. Read the comment docs.

@supaiku0 supaiku0 merged commit daddd2f into develop Oct 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@supaiku0 supaiku0 deleted the core-debugger-cli branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment