New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: temporary 503 ban #1050

Merged
merged 4 commits into from Oct 3, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Oct 3, 2018

Proposed changes

This PR adds a very short 503 ban without any weight penalty that could result in a longer ban, as discussed with @air1one yesterday.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested review from supaiku0 and air1one Oct 3, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 3, 2018

Codecov Report

Merging #1050 into develop will increase coverage by 0.59%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1050      +/-   ##
===========================================
+ Coverage    72.63%   73.23%   +0.59%     
===========================================
  Files          417      417              
  Lines         6809     6811       +2     
  Branches       863      867       +4     
===========================================
+ Hits          4946     4988      +42     
+ Misses        1662     1628      -34     
+ Partials       201      195       -6
Impacted Files Coverage Δ
packages/core-p2p/lib/court/offences.js 100% <ø> (ø) ⬆️
packages/core-p2p/lib/court/guard.js 78.26% <100%> (+0.64%) ⬆️
packages/crypto/lib/models/transaction.js 80.86% <0%> (+0.47%) ⬆️
packages/crypto/lib/models/block.js 73.36% <0%> (+0.87%) ⬆️
...p2p/lib/server/versions/internal/handlers/utils.js 86.66% <0%> (+6.66%) ⬆️
...ackages/core-p2p/lib/server/plugins/set-headers.js 100% <0%> (+8.33%) ⬆️
packages/core-forger/lib/manager.js 81.52% <0%> (+8.69%) ⬆️
...es/core-p2p/lib/server/plugins/blockchain-ready.js 100% <0%> (+10%) ⬆️
...kages/core-debugger-cli/lib/utils/handle-output.js 71.42% <0%> (+71.42%) ⬆️
...ages/core-debugger-cli/lib/commands/deserialize.js 100% <0%> (+100%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c71f00...c7c26ef. Read the comment docs.

codecov-io commented Oct 3, 2018

Codecov Report

Merging #1050 into develop will increase coverage by 0.59%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1050      +/-   ##
===========================================
+ Coverage    72.63%   73.23%   +0.59%     
===========================================
  Files          417      417              
  Lines         6809     6811       +2     
  Branches       863      867       +4     
===========================================
+ Hits          4946     4988      +42     
+ Misses        1662     1628      -34     
+ Partials       201      195       -6
Impacted Files Coverage Δ
packages/core-p2p/lib/court/offences.js 100% <ø> (ø) ⬆️
packages/core-p2p/lib/court/guard.js 78.26% <100%> (+0.64%) ⬆️
packages/crypto/lib/models/transaction.js 80.86% <0%> (+0.47%) ⬆️
packages/crypto/lib/models/block.js 73.36% <0%> (+0.87%) ⬆️
...p2p/lib/server/versions/internal/handlers/utils.js 86.66% <0%> (+6.66%) ⬆️
...ackages/core-p2p/lib/server/plugins/set-headers.js 100% <0%> (+8.33%) ⬆️
packages/core-forger/lib/manager.js 81.52% <0%> (+8.69%) ⬆️
...es/core-p2p/lib/server/plugins/blockchain-ready.js 100% <0%> (+10%) ⬆️
...kages/core-debugger-cli/lib/utils/handle-output.js 71.42% <0%> (+71.42%) ⬆️
...ages/core-debugger-cli/lib/commands/deserialize.js 100% <0%> (+100%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c71f00...c7c26ef. Read the comment docs.

@faustbrian faustbrian merged commit 98758ef into develop Oct 3, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@faustbrian faustbrian deleted the 503-ban branch Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment