New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: transaction builder verification #1055

Merged
merged 8 commits into from Oct 4, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Oct 3, 2018

Proposed changes

This adds tests to verify that the transactions that are build actually verify. @alexbarnsley discovered that some transaction types fail to verify or get rejected by nodes.

Multisigs are still to do as they currently completely fail, thought we could skip them for now until aip18 is implemented.

Types of changes

  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@faustbrian faustbrian requested review from supaiku0, alexbarnsley and air1one Oct 3, 2018

@faustbrian faustbrian changed the title from [WIP] test: transaction builder verification to test: transaction builder verification Oct 4, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 4, 2018

Codecov Report

Merging #1055 into develop will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1055      +/-   ##
===========================================
+ Coverage    73.03%   73.19%   +0.16%     
===========================================
  Files          417      417              
  Lines         6812     6812              
  Branches       868      868              
===========================================
+ Hits          4975     4986      +11     
+ Misses        1639     1631       -8     
+ Partials       198      195       -3
Impacted Files Coverage Δ
...ges/crypto/lib/builder/transactions/transaction.js 84.78% <100%> (ø) ⬆️
...p2p/lib/server/versions/internal/handlers/utils.js 86.66% <0%> (+6.66%) ⬆️
packages/core-p2p/lib/utils/check-ntp.js 100% <0%> (+7.14%) ⬆️
packages/core-forger/lib/manager.js 81.52% <0%> (+9.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2600e5...5bc91c8. Read the comment docs.

codecov-io commented Oct 4, 2018

Codecov Report

Merging #1055 into develop will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1055      +/-   ##
===========================================
+ Coverage    73.03%   73.19%   +0.16%     
===========================================
  Files          417      417              
  Lines         6812     6812              
  Branches       868      868              
===========================================
+ Hits          4975     4986      +11     
+ Misses        1639     1631       -8     
+ Partials       198      195       -3
Impacted Files Coverage Δ
...ges/crypto/lib/builder/transactions/transaction.js 84.78% <100%> (ø) ⬆️
...p2p/lib/server/versions/internal/handlers/utils.js 86.66% <0%> (+6.66%) ⬆️
packages/core-p2p/lib/utils/check-ntp.js 100% <0%> (+7.14%) ⬆️
packages/core-forger/lib/manager.js 81.52% <0%> (+9.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2600e5...5bc91c8. Read the comment docs.

faustbrian and others added some commits Oct 4, 2018

@faustbrian faustbrian merged commit 506b8c5 into develop Oct 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@faustbrian faustbrian deleted the crypto-verify-test branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment