diff --git a/packages/crypto/__tests__/builder/transactions/delegate-registration.test.js b/packages/crypto/__tests__/builder/transactions/delegate-registration.test.js index d5854ce69c..8d2031d822 100644 --- a/packages/crypto/__tests__/builder/transactions/delegate-registration.test.js +++ b/packages/crypto/__tests__/builder/transactions/delegate-registration.test.js @@ -13,6 +13,25 @@ beforeEach(() => { }) describe('Delegate Registration Transaction', () => { + describe('verify', () => { + it('should be valid with a signature', () => { + const actual = builder + .usernameAsset('homer') + .sign('dummy passphrase') + + expect(actual.build().verify()).toBeTrue() + }) + + it('should be valid with a second signature', () => { + const actual = builder + .usernameAsset('homer') + .sign('dummy passphrase') + .secondSign('dummy passphrase') + + expect(actual.build().verify()).toBeTrue() + }) + }) + transactionBuilderTests() it('should have its specific properties', () => { diff --git a/packages/crypto/__tests__/builder/transactions/multi-signature.test.js b/packages/crypto/__tests__/builder/transactions/multi-signature.test.js index a1e922693e..1706a2cec0 100644 --- a/packages/crypto/__tests__/builder/transactions/multi-signature.test.js +++ b/packages/crypto/__tests__/builder/transactions/multi-signature.test.js @@ -13,6 +13,27 @@ beforeEach(() => { }) describe('Multi Signature Transaction', () => { + describe('verify', () => { + it('should be valid with a signature', () => { + const actual = builder + .multiSignatureAsset({ + keysgroup: [ + '+0376982a97dadbc65e694743d386084548a65431a82ce935ac9d957b1cffab2784', + '+03793904e0df839809bc89f2839e1ae4f8b1ea97ede6592b7d1e4d0ee194ca2998', + '+03e710267cdbc87cf8c2f32a6c3f22e1d1ce22ba30e1915360f511a2b16df8c5a5' + ], + lifetime: 72, + min: 2 + }) + .sign('dummy passphrase') + .multiSignatureSign('multi passphrase 1') + .multiSignatureSign('multi passphrase 2') + .multiSignatureSign('multi passphrase 3') + + expect(actual.build().verify()).toBeTrue() + }) + }) + transactionBuilderTests() it('should have its specific properties', () => { diff --git a/packages/crypto/__tests__/builder/transactions/second-signature.test.js b/packages/crypto/__tests__/builder/transactions/second-signature.test.js index 432204e264..1edc655830 100644 --- a/packages/crypto/__tests__/builder/transactions/second-signature.test.js +++ b/packages/crypto/__tests__/builder/transactions/second-signature.test.js @@ -13,6 +13,16 @@ beforeEach(() => { }) describe('Second Signature Transaction', () => { + describe('verify', () => { + it('should be valid with a signature', () => { + const actual = builder + .signatureAsset('signature') + .sign('dummy passphrase') + + expect(actual.build().verify()).toBeTrue() + }) + }) + transactionBuilderTests() it('should have its specific properties', () => { diff --git a/packages/crypto/__tests__/builder/transactions/transfer.test.js b/packages/crypto/__tests__/builder/transactions/transfer.test.js index 4ab2912211..5b0d3df57f 100644 --- a/packages/crypto/__tests__/builder/transactions/transfer.test.js +++ b/packages/crypto/__tests__/builder/transactions/transfer.test.js @@ -12,6 +12,29 @@ beforeEach(() => { }) describe('Transfer Transaction', () => { + describe('verify', () => { + it('should be valid with a signature', () => { + const actual = builder + .recipientId('D5q7YfEFDky1JJVQQEy4MGyiUhr5cGg47F') + .amount(1) + .vendorField('dummy') + .sign('dummy passphrase') + + expect(actual.build().verify()).toBeTrue() + }) + + it('should be valid with a second signature', () => { + const actual = builder + .recipientId('D5q7YfEFDky1JJVQQEy4MGyiUhr5cGg47F') + .amount(1) + .vendorField('dummy') + .sign('dummy passphrase') + .secondSign('dummy passphrase') + + expect(actual.build().verify()).toBeTrue() + }) + }) + transactionBuilderTests() it('should have its specific properties', () => { diff --git a/packages/crypto/__tests__/builder/transactions/vote.test.js b/packages/crypto/__tests__/builder/transactions/vote.test.js index 51d5a1dbe5..ebb8b98cbe 100644 --- a/packages/crypto/__tests__/builder/transactions/vote.test.js +++ b/packages/crypto/__tests__/builder/transactions/vote.test.js @@ -13,6 +13,25 @@ beforeEach(() => { }) describe('Vote Transaction', () => { + describe('verify', () => { + it('should be valid with a signature', () => { + const actual = builder + .votesAsset(['+02d0d835266297f15c192be2636eb3fbc30b39b87fc583ff112062ef8ae1a1f2af']) + .sign('dummy passphrase') + + expect(actual.build().verify()).toBeTrue() + }) + + it('should be valid with a second signature', () => { + const actual = builder + .votesAsset(['+02d0d835266297f15c192be2636eb3fbc30b39b87fc583ff112062ef8ae1a1f2af']) + .sign('dummy passphrase') + .secondSign('dummy passphrase') + + expect(actual.build().verify()).toBeTrue() + }) + }) + transactionBuilderTests() it('should have its specific properties', () => { diff --git a/packages/crypto/lib/builder/transactions/transaction.js b/packages/crypto/lib/builder/transactions/transaction.js index 51fd1e9c4e..3d372e6cd5 100644 --- a/packages/crypto/lib/builder/transactions/transaction.js +++ b/packages/crypto/lib/builder/transactions/transaction.js @@ -195,7 +195,7 @@ module.exports = class TransactionBuilder { const { data } = this Object.keys(data).forEach(key => { - if (['model', 'id'].includes(key)) { + if (['model', 'network', 'id'].includes(key)) { delete data[key] } })