New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return false instead of throwing #1087

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Oct 10, 2018

Proposed changes

This replaces the thrown error with a response as this is the v1 P2P API and errors are handled as success: false. Because this error was unhandled it would get caught as an unhandled exception.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested review from air1one, alexbarnsley and supaiku0 Oct 10, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 10, 2018

Codecov Report

Merging #1087 into develop will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1087      +/-   ##
===========================================
+ Coverage    77.15%   77.19%   +0.04%     
===========================================
  Files          423      423              
  Lines         6871     6871              
  Branches       884      884              
===========================================
+ Hits          5301     5304       +3     
+ Misses        1398     1396       -2     
+ Partials       172      171       -1
Impacted Files Coverage Δ
...ackages/core-p2p/lib/server/versions/1/handlers.js 52.21% <0%> (ø) ⬆️
...ages/core-p2p/lib/server/plugins/accept-request.js 86.36% <0%> (+4.54%) ⬆️
...ackages/core-p2p/lib/server/plugins/set-headers.js 88.88% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f59647...0a2282f. Read the comment docs.

codecov-io commented Oct 10, 2018

Codecov Report

Merging #1087 into develop will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1087      +/-   ##
===========================================
+ Coverage    77.15%   77.19%   +0.04%     
===========================================
  Files          423      423              
  Lines         6871     6871              
  Branches       884      884              
===========================================
+ Hits          5301     5304       +3     
+ Misses        1398     1396       -2     
+ Partials       172      171       -1
Impacted Files Coverage Δ
...ackages/core-p2p/lib/server/versions/1/handlers.js 52.21% <0%> (ø) ⬆️
...ages/core-p2p/lib/server/plugins/accept-request.js 86.36% <0%> (+4.54%) ⬆️
...ackages/core-p2p/lib/server/plugins/set-headers.js 88.88% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f59647...0a2282f. Read the comment docs.

@faustbrian faustbrian merged commit dad2af4 into develop Oct 10, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@faustbrian faustbrian deleted the faustbrian-patch-1 branch Oct 10, 2018

vasild added a commit that referenced this pull request Oct 10, 2018

Merge remote-tracking branch 'ArkEcosystem/core/develop' into feat/tr…
…ansaction-pool-mem

* ArkEcosystem/core/develop:
  fix: return false instead of throwing (#1087)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment