New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove client package #1261

Merged
merged 2 commits into from Nov 1, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Nov 1, 2018

Proposed changes

The javascript-client isn't a part of core like crypto. A week ago it was moved to https://github.com/ArkEcosystem/javascript-client to remove it from here and make it easier to use it during development by being able to require the repository.

Types of changes

  • Other

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from supaiku0 Nov 1, 2018

@wafflebot wafflebot bot added the review label Nov 1, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 1, 2018

Codecov Report

Merging #1261 into develop will decrease coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1261      +/-   ##
===========================================
- Coverage    78.88%   78.25%   -0.64%     
===========================================
  Files          413      391      -22     
  Lines         7005     6857     -148     
  Branches       942      940       -2     
===========================================
- Hits          5526     5366     -160     
- Misses        1307     1316       +9     
- Partials       172      175       +3
Impacted Files Coverage Δ
packages/core-forger/lib/manager.js 71.73% <0%> (-9.79%) ⬇️
...p2p/lib/server/versions/internal/handlers/utils.js 80% <0%> (-6.67%) ⬇️
packages/core-blockchain/lib/blockchain.js 77.11% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b89bd2b...8f32c7e. Read the comment docs.

@faustbrian faustbrian merged commit b5e2b89 into develop Nov 1, 2018

1 check passed

ci/circleci: test-node10 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the client branch Nov 1, 2018

@wafflebot wafflebot bot removed the review label Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment