New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add core-vote-report package #1263

Merged
merged 17 commits into from Nov 2, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Nov 1, 2018

Proposed changes

Adds an optional package to generate the popular vote report https://explorer.ark.io/VoteReport.txt based on in-memory data which will show real-time data.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from supaiku0 Nov 1, 2018

@wafflebot wafflebot bot added the review label Nov 1, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 1, 2018

Codecov Report

Merging #1263 into develop will decrease coverage by 0.49%.
The diff coverage is 4.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #1263     +/-   ##
==========================================
- Coverage    78.28%   77.79%   -0.5%     
==========================================
  Files          393      396      +3     
  Lines         6863     6903     +40     
  Branches       942      945      +3     
==========================================
- Hits          5373     5370      -3     
- Misses        1312     1350     +38     
- Partials       178      183      +5
Impacted Files Coverage Δ
packages/core-vote-report/lib/handler.js 0% <0%> (ø)
packages/core-vote-report/lib/server.js 0% <0%> (ø)
packages/core-vote-report/lib/defaults.js 0% <0%> (ø)
packages/core-http-utils/lib/server/create.js 90% <66.66%> (-10%) ⬇️
packages/core-forger/lib/manager.js 72.82% <0%> (-8.7%) ⬇️
packages/core-blockchain/lib/state-machine.js 45.55% <0%> (+0.55%) ⬆️
...es/core-p2p/lib/server/plugins/blockchain-ready.js 100% <0%> (+10%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66702a1...a91ece0. Read the comment docs.

faustbrian and others added some commits Nov 1, 2018

refactor(core-vote-report): only wallets with balance > 0.1 (#1274)
* refactor(core-vote-report): only wallets with balance > 0.1

* refactor(core-vote-report): format voter count string

@faustbrian faustbrian merged commit a74725f into develop Nov 2, 2018

1 check passed

ci/circleci: test-node10 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the vote-report branch Nov 2, 2018

@wafflebot wafflebot bot removed the review label Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment