New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add core-elasticsearch package #1264

Merged
merged 15 commits into from Nov 6, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Nov 1, 2018

Proposed changes

Adds an optional elasticsearch integration to provide more powerful searching capabilities for large datasets.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from supaiku0 Nov 1, 2018

@wafflebot wafflebot bot added the review label Nov 1, 2018

faustbrian added some commits Nov 1, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 1, 2018

Codecov Report

Merging #1264 into develop will decrease coverage by 0.58%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1264      +/-   ##
==========================================
- Coverage    75.08%   74.5%   -0.59%     
==========================================
  Files          416     422       +6     
  Lines         7272    7318      +46     
  Branches       988     990       +2     
==========================================
- Hits          5460    5452       -8     
- Misses        1596    1645      +49     
- Partials       216     221       +5
Impacted Files Coverage Δ
packages/core-blockchain/lib/blockchain.js 77.11% <ø> (ø) ⬆️
packages/core-elasticsearch/lib/server/index.js 0% <0%> (ø)
...ackages/core-elasticsearch/lib/services/storage.js 0% <0%> (ø)
packages/core-elasticsearch/lib/defaults.js 0% <0%> (ø)
packages/core-elasticsearch/lib/services/client.js 0% <0%> (ø)
packages/core-elasticsearch/lib/server/routes.js 0% <0%> (ø)
packages/core-elasticsearch/lib/server/handler.js 0% <0%> (ø)
packages/core-database-postgres/lib/connection.js 75.55% <100%> (+0.21%) ⬆️
packages/core-forger/lib/manager.js 72.63% <0%> (-9.48%) ⬇️
...p2p/lib/server/versions/internal/handlers/utils.js 80% <0%> (-6.67%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d625949...5e40ad5. Read the comment docs.

faustbrian added some commits Nov 3, 2018

@faustbrian

This comment has been minimized.

Collaborator

faustbrian commented Nov 5, 2018

We should leave this open until #1176 is merged because I can remove a bunch of code after created_at and updated_at no longer exist.

@faustbrian faustbrian changed the title from feat: add core-elasticsearch package to [WIP] feat: add core-elasticsearch package Nov 5, 2018

@kristjank kristjank added in progress and removed review labels Nov 5, 2018

@wafflebot wafflebot bot added review and removed in progress labels Nov 5, 2018

@faustbrian faustbrian changed the title from [WIP] feat: add core-elasticsearch package to  feat: add core-elasticsearch package Nov 5, 2018

@faustbrian faustbrian changed the title from  feat: add core-elasticsearch package to feat: add core-elasticsearch package Nov 5, 2018

@faustbrian faustbrian merged commit 939398d into develop Nov 6, 2018

1 check passed

ci/circleci: test-node10 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the elastic branch Nov 6, 2018

@wafflebot wafflebot bot removed the review label Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment