New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add core-error-tracker-sentry package #1265

Merged
merged 9 commits into from Nov 1, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Nov 1, 2018

Proposed changes

Adds support for error tracking and monitoring via https://docs.sentry.io/quickstart/?platform=node so node maintainers can provide better feedback if they decide to use a proper monitoring service for their node.

Other integrations will follow in the next days to provide a variety of services.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from supaiku0 Nov 1, 2018

@wafflebot wafflebot bot added the review label Nov 1, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 1, 2018

Codecov Report

Merging #1265 into develop will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1265      +/-   ##
===========================================
- Coverage    78.88%   78.73%   -0.16%     
===========================================
  Files          413      414       +1     
  Lines         7005     7006       +1     
  Branches       942      942              
===========================================
- Hits          5526     5516      -10     
- Misses        1307     1315       +8     
- Partials       172      175       +3
Impacted Files Coverage Δ
packages/core-error-tracker-sentry/lib/defaults.js 0% <0%> (ø)
packages/core-forger/lib/manager.js 71.73% <0%> (-9.79%) ⬇️
...p2p/lib/server/versions/internal/handlers/utils.js 80% <0%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b89bd2b...0e9cd13. Read the comment docs.

faustbrian and others added some commits Nov 1, 2018

@faustbrian faustbrian merged commit 579bb26 into develop Nov 1, 2018

1 check was pending

ci/circleci: test-node10 CircleCI is running your tests
Details

@wafflebot wafflebot bot removed the review label Nov 1, 2018

@faustbrian faustbrian deleted the sentry branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment