New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-http-utils): add cors-headers plugin #1283

Merged
merged 2 commits into from Nov 3, 2018

Conversation

Projects
None yet
2 participants
@faustbrian
Collaborator

faustbrian commented Nov 3, 2018

Proposed changes

Based on https://github.com/gr2m/hapi-cors-headers which offers better CORS handling to resolve some issues that popped up with the desktop wallet.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@wafflebot wafflebot bot added the review label Nov 3, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 3, 2018

Codecov Report

Merging #1283 into develop will decrease coverage by 0.12%.
The diff coverage is 31.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1283      +/-   ##
===========================================
- Coverage    77.85%   77.72%   -0.13%     
===========================================
  Files          396      397       +1     
  Lines         6903     6922      +19     
  Branches       945      951       +6     
===========================================
+ Hits          5374     5380       +6     
- Misses        1349     1357       +8     
- Partials       180      185       +5
Impacted Files Coverage Δ
packages/core-api/lib/server.js 94.44% <100%> (+0.32%) ⬆️
...ckages/core-http-utils/lib/plugins/cors-headers.js 27.77% <27.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a74725f...0ea85e6. Read the comment docs.

@faustbrian faustbrian merged commit a9ce9bb into develop Nov 3, 2018

1 check passed

ci/circleci: test-node10 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the cors branch Nov 3, 2018

@wafflebot wafflebot bot removed the review label Nov 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment