New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use 1e8 instead of math.pow #1284

Merged
merged 3 commits into from Nov 3, 2018

Conversation

Projects
None yet
2 participants
@faustbrian
Collaborator

faustbrian commented Nov 3, 2018

Proposed changes

Replaces Math.pow(10, 8) with 1e8 as it is quicker to type and yields the same result, just a syntax nitpick.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from supaiku0 Nov 3, 2018

@wafflebot wafflebot bot added the review label Nov 3, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 3, 2018

Codecov Report

Merging #1284 into develop will decrease coverage by 0.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1284      +/-   ##
===========================================
- Coverage    77.73%   77.67%   -0.06%     
===========================================
  Files          397      397              
  Lines         6925     6925              
  Branches       952      952              
===========================================
- Hits          5383     5379       -4     
- Misses        1357     1358       +1     
- Partials       185      188       +3
Impacted Files Coverage Δ
packages/core-vote-report/lib/handler.js 0% <0%> (ø) ⬆️
packages/crypto/lib/constants.js 100% <100%> (ø) ⬆️
packages/core-forger/lib/manager.js 72.82% <0%> (-8.7%) ⬇️
packages/core-blockchain/lib/state-machine.js 45.55% <0%> (+0.55%) ⬆️
...es/core-p2p/lib/server/plugins/blockchain-ready.js 100% <0%> (+10%) ⬆️
...p2p/lib/server/versions/internal/handlers/utils.js 100% <0%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb87b12...fd3b74b. Read the comment docs.

faustbrian added some commits Nov 3, 2018

@faustbrian faustbrian merged commit 0ab4297 into develop Nov 3, 2018

1 check passed

ci/circleci: test-node10 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the expo branch Nov 3, 2018

@wafflebot wafflebot bot removed the review label Nov 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment