New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-forger): properly exit if no forgers are configured #1294

Merged
merged 5 commits into from Nov 6, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Nov 5, 2018

Proposed changes

Currently the forger gives no errors or indications when no forger is configured. This PR will add messages to let the user know that no forger is configured.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested review from supaiku0, alexbarnsley and air1one Nov 5, 2018

@wafflebot wafflebot bot added the review label Nov 5, 2018

faustbrian added some commits Nov 5, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 5, 2018

Codecov Report

Merging #1294 into develop will decrease coverage by 0.13%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1294      +/-   ##
===========================================
- Coverage    74.45%   74.32%   -0.14%     
===========================================
  Files          422      422              
  Lines         7336     7337       +1     
  Branches       994      994              
===========================================
- Hits          5462     5453       -9     
- Misses        1653     1660       +7     
- Partials       221      224       +3
Impacted Files Coverage Δ
packages/core-forger/lib/manager.js 70.83% <33.33%> (-11.28%) ⬇️
...p2p/lib/server/versions/internal/handlers/utils.js 80% <0%> (-6.67%) ⬇️
packages/core-blockchain/lib/blockchain.js 78.1% <0%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 903b562...d40a0ca. Read the comment docs.

@faustbrian faustbrian changed the title from fix: properly exit if no forgers are configured to fix(core-forger): properly exit if no forgers are configured Nov 6, 2018

@air1one

air1one approved these changes Nov 6, 2018

@faustbrian faustbrian merged commit 3989037 into develop Nov 6, 2018

1 check passed

ci/circleci: test-node10 Your tests passed on CircleCI!
Details

@wafflebot wafflebot bot removed the review label Nov 6, 2018

@faustbrian faustbrian deleted the forger branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment