fix(core-forger): properly exit if no forgers are configured

packages/core-forger/__tests__/manager.test.js

@@ -33,11 +33,6 @@ describe('Forger Manager', () => {
       expect(forgeManager.loadDelegates).toBeFunction()
     })
 
-    it('should throw an error without configured delegates', async () => {
-      forgeManager.secrets = null
-      await expect(forgeManager.loadDelegates()).rejects.toThrowError('No delegate found')
-    })
-
     it('should be ok with configured delegates', async () => {
       let secret = 'a secret'
       forgeManager.secrets = [secret]

packages/core-forger/lib/index.js

@@ -14,6 +14,11 @@ exports.plugin = {
     const forgerManager = new ForgerManager(options)
     const forgers = await forgerManager.loadDelegates(options.bip38, options.password)
 
+    if (!forgers) {
+      container.resolvePlugin('logger').info('Forger is disabled :grey_exclamation:')
+      return
+    }
+
     // Don't keep bip38 password in memory
     delete process.env.ARK_FORGER_PASSWORD
     delete options.password
@@ -25,8 +30,12 @@ exports.plugin = {
     return forgerManager
   },
   async deregister (container, options) {
-    container.resolvePlugin('logger').info('Stopping Forger Manager')
+    const forger = container.resolvePlugin('forger')
+
+    if (forger) {
+      container.resolvePlugin('logger').info('Stopping Forger Manager')
 
-    await container.resolvePlugin('forger').stop()
+      return forger.stop()
+    }
   }
 }

packages/core-forger/lib/manager.js

@@ -31,8 +31,9 @@ module.exports = class ForgerManager {
    * @return {Array}
    */
   async loadDelegates (bip38, password) {
-    if (!bip38 && !this.secrets) {
-      throw new Error('No delegate found')
+    if (!bip38 && (!this.secrets || !this.secrets.length || !Array.isArray(this.secrets))) {
+      logger.warn('No delegate found! Please check your "delegates.json" file and try again.')
+      return
     }
 
     this.delegates = this.secrets.map(passphrase => new Delegate(passphrase, this.network, password))