New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-database-postgres): fix sorting of votes during SPV #1303

Merged
merged 2 commits into from Nov 6, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Nov 6, 2018

Proposed changes

Resolves the vote sorting issue during the SPV.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested review from kristjank and fix Nov 6, 2018

@wafflebot wafflebot bot added the review label Nov 6, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 6, 2018

Codecov Report

Merging #1303 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1303   +/-   ##
========================================
  Coverage    74.43%   74.43%           
========================================
  Files          422      422           
  Lines         7345     7345           
  Branches       994      994           
========================================
  Hits          5467     5467           
  Misses        1657     1657           
  Partials       221      221

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228867a...cbd9e27. Read the comment docs.

@faustbrian faustbrian requested a review from supaiku0 Nov 6, 2018

@faustbrian faustbrian merged commit f03eac1 into develop Nov 6, 2018

1 check passed

ci/circleci: test-node10 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the order branch Nov 6, 2018

@wafflebot wafflebot bot removed the review label Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment