New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-container): configure via remote peer #1309

Merged
merged 15 commits into from Nov 8, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Nov 7, 2018

Proposed changes

Resolves #1002.

yarn relay --remote ip:p2p-port

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from supaiku0 Nov 7, 2018

@wafflebot wafflebot bot added the review label Nov 7, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 7, 2018

Codecov Report

Merging #1309 into develop will decrease coverage by 0.22%.
The diff coverage is 63.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1309      +/-   ##
==========================================
- Coverage    74.02%   73.8%   -0.23%     
==========================================
  Files          422     423       +1     
  Lines         7400    7460      +60     
  Branches      1006    1010       +4     
==========================================
+ Hits          5478    5506      +28     
- Misses        1692    1720      +28     
- Partials       230     234       +4
Impacted Files Coverage Δ
...kages/core-p2p/lib/server/versions/config/index.js 100% <ø> (ø) ⬆️
...e-p2p/lib/server/versions/config/handlers/index.js 50% <36.36%> (-30%) ⬇️
packages/core-container/lib/container.js 52.54% <50%> (-0.19%) ⬇️
packages/core-container/lib/remote-loader.js 71.11% <71.11%> (ø)
packages/core-forger/lib/manager.js 70.1% <0%> (-9.28%) ⬇️
...p2p/lib/server/versions/internal/handlers/utils.js 80% <0%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9245249...abc9312. Read the comment docs.

faustbrian added some commits Nov 7, 2018

__configureDatabase (network) {
const command = spawnSync('createdb', [`ark_${network.name}`])
if (command.stderr) {

This comment has been minimized.

@supaiku0

supaiku0 Nov 8, 2018

Contributor

This always evaluates to true for me. Adding command.stderr.length > 0 fixes it.

faustbrian added some commits Nov 8, 2018

changes made

@faustbrian faustbrian merged commit f33cf7d into develop Nov 8, 2018

1 check passed

ci/circleci: test-node10 Your tests passed on CircleCI!
Details

@wafflebot wafflebot bot removed the review label Nov 8, 2018

@faustbrian faustbrian deleted the remote-config branch Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment