New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): make sure state is ready in guard #1311

Merged
merged 4 commits into from Nov 7, 2018

Conversation

Projects
None yet
2 participants
@faustbrian
Collaborator

faustbrian commented Nov 7, 2018

Proposed changes

Only checks for fork causing peers if the state is ready.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@wafflebot wafflebot bot added the review label Nov 7, 2018

faustbrian added some commits Nov 7, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 7, 2018

Codecov Report

Merging #1311 into develop will decrease coverage by 0.03%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1311      +/-   ##
===========================================
- Coverage    74.26%   74.23%   -0.04%     
===========================================
  Files          422      422              
  Lines         7353     7355       +2     
  Branches       995      995              
===========================================
- Hits          5461     5460       -1     
- Misses        1669     1670       +1     
- Partials       223      225       +2
Impacted Files Coverage Δ
packages/core-p2p/lib/court/guard.js 75.94% <60%> (-0.68%) ⬇️
packages/core-forger/lib/manager.js 76.28% <0%> (-3.1%) ⬇️
...p2p/lib/server/versions/internal/handlers/utils.js 93.33% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2349439...ee59774. Read the comment docs.

@faustbrian faustbrian merged commit f4bd3a4 into develop Nov 7, 2018

1 check passed

ci/circleci: test-node10 Your tests passed on CircleCI!
Details

@wafflebot wafflebot bot removed the review label Nov 7, 2018

@faustbrian faustbrian deleted the guard branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment