New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup node 11 for CircleCI #1312

Merged
merged 3 commits into from Nov 7, 2018

Conversation

Projects
None yet
2 participants
@faustbrian
Collaborator

faustbrian commented Nov 7, 2018

Proposed changes

Adds support for node.js 11 as CircleCI now has an image for that. Currently disabled as there are known SQLite build issues on node.js 11.

Types of changes

  • Build (changes that affect the build system)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@wafflebot wafflebot bot added the review label Nov 7, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 7, 2018

Codecov Report

Merging #1312 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1312      +/-   ##
===========================================
- Coverage    74.26%   74.23%   -0.03%     
===========================================
  Files          422      422              
  Lines         7355     7355              
  Branches       995      995              
===========================================
- Hits          5462     5460       -2     
  Misses        1670     1670              
- Partials       223      225       +2
Impacted Files Coverage Δ
packages/core-forger/lib/manager.js 76.28% <0%> (-3.1%) ⬇️
...p2p/lib/server/versions/internal/handlers/utils.js 93.33% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4bd3a4...d2e057b. Read the comment docs.

@faustbrian faustbrian merged commit bbcb356 into develop Nov 7, 2018

1 check passed

ci/circleci: test-node10 Your tests passed on CircleCI!
Details

@wafflebot wafflebot bot removed the review label Nov 7, 2018

@faustbrian faustbrian deleted the node-11 branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment