New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-transaction-pool): handle unexpected transaction errors in guard #1322

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
2 participants
@faustbrian
Collaborator

faustbrian commented Nov 8, 2018

Proposed changes

Invalidates a transaction when an unexpected errors occurs instead of returning a code 500.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@wafflebot wafflebot bot added the review label Nov 8, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 8, 2018

Codecov Report

Merging #1322 into develop will decrease coverage by 0.14%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1322      +/-   ##
==========================================
- Coverage    73.94%   73.8%   -0.15%     
==========================================
  Files          423     423              
  Lines         7460    7462       +2     
  Branches      1010    1010              
==========================================
- Hits          5516    5507       -9     
- Misses        1713    1721       +8     
- Partials       231     234       +3
Impacted Files Coverage Δ
packages/core-transaction-pool/lib/guard.js 83.72% <66.66%> (-0.81%) ⬇️
packages/core-forger/lib/manager.js 70.1% <0%> (-9.28%) ⬇️
...p2p/lib/server/versions/internal/handlers/utils.js 80% <0%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f33cf7d...bdaac6b. Read the comment docs.

@faustbrian faustbrian merged commit bf04094 into develop Nov 8, 2018

1 check passed

ci/circleci: test-node10 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the validate branch Nov 8, 2018

@wafflebot wafflebot bot removed the review label Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment