New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-p2p): add flag to disable peer discovery #1326

Merged
merged 7 commits into from Nov 8, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Nov 8, 2018

Proposed changes

Follow up to #1325. Also fixes that the --network-start flag did not work for relays.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

faustbrian added some commits Nov 8, 2018

@wafflebot wafflebot bot added the review label Nov 8, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 8, 2018

Codecov Report

Merging #1326 into develop will decrease coverage by 0.12%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1326      +/-   ##
===========================================
- Coverage    74.15%   74.02%   -0.13%     
===========================================
  Files          421      420       -1     
  Lines         7432     7434       +2     
  Branches      1006     1007       +1     
===========================================
- Hits          5511     5503       -8     
- Misses        1696     1703       +7     
- Partials       225      228       +3
Impacted Files Coverage Δ
packages/core/lib/start-relay.js 0% <0%> (ø) ⬆️
packages/core/lib/start-forger.js 0% <0%> (ø) ⬆️
packages/core/lib/start-relay-and-forger.js 0% <0%> (ø) ⬆️
packages/core-p2p/lib/monitor.js 61.27% <63.63%> (-0.65%) ⬇️
packages/core-forger/lib/manager.js 70.1% <0%> (-9.28%) ⬇️
...p2p/lib/server/versions/internal/handlers/utils.js 80% <0%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3f514...ff97e34. Read the comment docs.

@faustbrian faustbrian requested review from alexbarnsley and supaiku0 Nov 8, 2018

@faustbrian faustbrian merged commit d9b649a into develop Nov 8, 2018

1 check passed

ci/circleci: test-node10 Your tests passed on CircleCI!
Details

@wafflebot wafflebot bot removed the review label Nov 8, 2018

@faustbrian faustbrian deleted the discovery-flags branch Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment