New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-p2p): add ability to skip initial peer discovery #1327

Merged
merged 3 commits into from Nov 8, 2018

Conversation

Projects
None yet
2 participants
@faustbrian
Collaborator

faustbrian commented Nov 8, 2018

Proposed changes

Starting nodes with --network-start will already skip the peer discovery but it will also skip a bunch of other things in regards to the state-machine. The --skip-discovery flag will allow a node to be started in normal mode and skip the initial peer discovery like --network-start does without any of the side effects.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@wafflebot wafflebot bot added the review label Nov 8, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 8, 2018

Codecov Report

Merging #1327 into develop will decrease coverage by 0.13%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1327      +/-   ##
===========================================
- Coverage    74.15%   74.02%   -0.14%     
===========================================
  Files          420      420              
  Lines         7434     7434              
  Branches      1007     1008       +1     
===========================================
- Hits          5513     5503      -10     
- Misses        1696     1703       +7     
- Partials       225      228       +3
Impacted Files Coverage Δ
packages/core/lib/start-relay.js 0% <ø> (ø) ⬆️
packages/core/lib/start-relay-and-forger.js 0% <ø> (ø) ⬆️
packages/core-p2p/lib/monitor.js 61.27% <50%> (ø) ⬆️
packages/core-forger/lib/manager.js 70.1% <0%> (-9.28%) ⬇️
...p2p/lib/server/versions/internal/handlers/utils.js 80% <0%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b649a...f62136a. Read the comment docs.

@faustbrian faustbrian merged commit 3350107 into develop Nov 8, 2018

1 check passed

ci/circleci: test-node10 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the skip-discovery branch Nov 8, 2018

@wafflebot wafflebot bot removed the review label Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment