New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(crypto): add exception for unicode transaction (#1318) #1329

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Nov 8, 2018

Proposed changes

Adds an exception for the unicode transaction from #1318.

Types of changes

  • Other

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@wafflebot wafflebot bot added the review label Nov 8, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 8, 2018

Codecov Report

Merging #1329 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1329      +/-   ##
===========================================
+ Coverage    74.14%   74.17%   +0.02%     
===========================================
  Files          419      419              
  Lines         7430     7430              
  Branches      1009     1009              
===========================================
+ Hits          5509     5511       +2     
+ Misses        1696     1694       -2     
  Partials       225      225
Impacted Files Coverage Δ
packages/core-blockchain/lib/state-machine.js 45.9% <0%> (+0.54%) ⬆️
...es/core-p2p/lib/server/plugins/blockchain-ready.js 100% <0%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f0719...9b70daf. Read the comment docs.

@supaiku0 supaiku0 self-requested a review Nov 8, 2018

@faustbrian faustbrian merged commit db42a03 into develop Nov 8, 2018

1 check passed

ci/circleci: test-node10 Your tests passed on CircleCI!
Details

@wafflebot wafflebot bot removed the review label Nov 8, 2018

@faustbrian faustbrian deleted the faustbrian-patch-1 branch Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment