New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-container): fixed hashid length #1551

Merged
merged 1 commit into from Dec 1, 2018

Conversation

Projects
None yet
3 participants
@zillionn
Contributor

zillionn commented Dec 1, 2018

Proposed changes

git rev-parse --short HEAD returns different revision lengths:

Discovered 15 peers on commit d0ec1f6.
Discovered 18 peers on commit d0ec1f6c.

--short[=length]
Same as --verify but shortens the object name to a unique prefix with at least length characters. The minimum length is 4, the default is the effective value of the core.abbrev configuration variable (see git-config[1]).

core.abbrev
Set the length object names are abbreviated to. If unspecified or set to "auto", an appropriate value is computed based on the approximate number of packed objects in your repository, which hopefully is enough for abbreviated object names to stay unique for some time. The minimum length is 4.

So I've changed the command to:
git rev-parse --short=8 HEAD

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@zillionn zillionn changed the title from fix(core-container): set hashid length to 8 to fix(core-container): fixed hashid length Dec 1, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Dec 1, 2018

Codecov Report

Merging #1551 into develop will increase coverage by 2.52%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1551      +/-   ##
===========================================
+ Coverage    72.22%   74.75%   +2.52%     
===========================================
  Files          479      439      -40     
  Lines         8727     7894     -833     
  Branches      1147     1038     -109     
===========================================
- Hits          6303     5901     -402     
+ Misses        2150     1770     -380     
+ Partials       274      223      -51
Impacted Files Coverage Δ
packages/core-container/lib/container.js 57.14% <ø> (ø) ⬆️
packages/core-forger/lib/manager.js 71.84% <0%> (-8.74%) ⬇️
...p2p/lib/server/versions/internal/handlers/utils.js 80% <0%> (-6.67%) ⬇️
packages/core-container/lib/index.js
packages/core-tester-cli/lib/utils/logger.js
packages/core-transaction-pool-mem/lib/index.js
packages/core-tester-cli/lib/config/index.js
...s/core-tester-cli/lib/commands/second-signature.js
packages/core-webhooks/lib/index.js
packages/core-database/lib/index.js
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0ec1f6...fe0b2d4. Read the comment docs.

@faustbrian faustbrian merged commit be4d2d6 into ArkEcosystem:develop Dec 1, 2018

4 checks passed

ci/circleci: depcheck-lint Your tests passed on CircleCI!
Details
ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details

@zillionn zillionn deleted the zillionn:hashid-length branch Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment