New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wrong CONTRIBUTING link #1560

Merged
merged 3 commits into from Dec 3, 2018

Conversation

Projects
None yet
3 participants
@zillionn
Contributor

zillionn commented Dec 3, 2018

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

faustbrian and others added some commits Dec 3, 2018

Merge pull request #1558 from ArkEcosystem/develop
merge develop to master
@codecov-io

This comment has been minimized.

codecov-io commented Dec 3, 2018

Codecov Report

Merging #1560 into develop will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1560      +/-   ##
===========================================
- Coverage    74.87%   74.75%   -0.13%     
===========================================
  Files          439      439              
  Lines         7894     7894              
  Branches      1038     1038              
===========================================
- Hits          5911     5901      -10     
- Misses        1763     1770       +7     
- Partials       220      223       +3
Impacted Files Coverage Δ
packages/core-forger/lib/manager.js 71.84% <0%> (-8.74%) ⬇️
...p2p/lib/server/versions/internal/handlers/utils.js 80% <0%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a80a2f...196549c. Read the comment docs.

@faustbrian faustbrian changed the base branch from master to develop Dec 3, 2018

@wafflebot wafflebot bot added the review label Dec 3, 2018

@faustbrian faustbrian merged commit 88b6c42 into ArkEcosystem:develop Dec 3, 2018

4 checks passed

ci/circleci: depcheck-lint Your tests passed on CircleCI!
Details
ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details

@wafflebot wafflebot bot removed the review label Dec 3, 2018

@faustbrian

This comment has been minimized.

Collaborator

faustbrian commented Dec 3, 2018

@zillionn next time please send the PR to develop.

@zillionn

This comment has been minimized.

Contributor

zillionn commented Dec 3, 2018

Oh, the master is default now. Sorry didn't see that.

@zillionn zillionn deleted the zillionn:patch-1 branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment