New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove jsdoc configs #1562

merged 1 commit into from Dec 3, 2018


None yet
2 participants

faustbrian commented Dec 3, 2018

Proposed changes

Removes the old jsdoc config files that are no longer used.

Types of changes

  • Other


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@wafflebot wafflebot bot added the review label Dec 3, 2018

@faustbrian faustbrian changed the base branch from master to develop Dec 3, 2018


This comment has been minimized.

codecov-io commented Dec 3, 2018

Codecov Report

Merging #1562 into develop will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1562      +/-   ##
- Coverage    74.87%   74.75%   -0.13%     
  Files          439      439              
  Lines         7894     7894              
  Branches      1038     1038              
- Hits          5911     5901      -10     
- Misses        1763     1770       +7     
- Partials       220      223       +3
Impacted Files Coverage Δ
packages/core-forger/lib/manager.js 71.84% <0%> (-8.74%) ⬇️
...p2p/lib/server/versions/internal/handlers/utils.js 80% <0%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b6c42...f258a5c. Read the comment docs.

@faustbrian faustbrian requested a review from supaiku0 Dec 3, 2018

@faustbrian faustbrian merged commit 1036fcc into develop Dec 3, 2018

4 checks passed

ci/circleci: depcheck-lint Your tests passed on CircleCI!
ci/circleci: test-node10-0 Your tests passed on CircleCI!
ci/circleci: test-node10-1 Your tests passed on CircleCI!
ci/circleci: test-node10-2 Your tests passed on CircleCI!

@faustbrian faustbrian deleted the jsdoc branch Dec 3, 2018

@wafflebot wafflebot bot removed the review label Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment