New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): return the correct total count for /api/v2/peers #1563

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@faustbrian
Collaborator

faustbrian commented Dec 3, 2018

Proposed changes

Return the correct total count for /api/v2/peers

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from supaiku0 Dec 3, 2018

@wafflebot wafflebot bot added the review label Dec 3, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Dec 3, 2018

Codecov Report

Merging #1563 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1563   +/-   ##
========================================
  Coverage    74.75%   74.75%           
========================================
  Files          439      439           
  Lines         7894     7894           
  Branches      1038     1038           
========================================
  Hits          5901     5901           
  Misses        1770     1770           
  Partials       223      223
Impacted Files Coverage Δ
packages/core-api/lib/versions/2/handlers/peers.js 61.76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1036fcc...6d88d6c. Read the comment docs.

@faustbrian faustbrian merged commit b0e5772 into develop Dec 3, 2018

4 checks passed

ci/circleci: depcheck-lint Your tests passed on CircleCI!
Details
ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details

@wafflebot wafflebot bot removed the review label Dec 3, 2018

@faustbrian faustbrian deleted the peer-count branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment