New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to typescript #1625

wants to merge 249 commits into
base: develop


None yet
6 participants

faustbrian commented Dec 4, 2018

Proposed changes

  • Resolves
  • Fixes a bug in core-container and resolveOptions that could result in null resolutions or providing options for plugins that are not even registered in the container
  • Fixed some return and value assignment issues where for example a BigNumber object was expected but a Number was assigned (JS didn't catch this and we had some tests that were passing even though they should have been failing)
  • Moved the peers.json config into the defaults of core-p2p as they are only used there and not by anything else (dc582fe). This means peers.json is now solely used to store the peer lists, more changes will follow in an upcoming PR.
  • Resolved various minor bugs that showed up during the migration
  • Added the yarn setup command to install, bootstrap and build all packages
  • Merged core-transaction-pool and core-transaction-pool-mem

Have been forging for some time with this branch on devnet now and had no errors occur so far.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Build (changes that affect the build system)


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@wafflebot wafflebot bot added the review label Dec 4, 2018


This comment has been minimized.

codecov-io commented Dec 4, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (develop@4a05143). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #1625   +/-   ##
  Coverage           ?   12.5%           
  Files              ?       8           
  Lines              ?       8           
  Branches           ?       0           
  Hits               ?       1           
  Misses             ?       7           
  Partials           ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a05143...c146337. Read the comment docs.

@faustbrian faustbrian requested a review from supaiku0 Dec 4, 2018

@faustbrian faustbrian changed the title from [WIP] refactor(core-config): migrate to typescript to refactor(core-config): migrate to typescript Dec 4, 2018

faustbrian added some commits Dec 4, 2018

@faustbrian faustbrian referenced this pull request Dec 11, 2018


[WIP] tests: Crypto delegate model #1694

4 of 12 tasks complete

This comment has been minimized.


faustbrian commented Dec 12, 2018

@kristjank @supaiku0 This should be ready to be merged, develop is merged and all tests fixed.

@supaiku0 has been forging for a day with it, me close to 3 days and @boldninja also has been running it for a day without any issues.

Once this is merged we will work on merging the open PRs from other people and then fix other issues and improvements. Also will need need to resolve the second-signature exceptions once this is merged.


This comment has been minimized.


kristjank commented Dec 12, 2018

will review this today, looking at it now.

@dated dated referenced this pull request Dec 12, 2018


[WIP] refactor: core 2.0 api #488

3 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment