New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1628

Merged
merged 8 commits into from Dec 4, 2018

Conversation

Projects
None yet
5 participants
@faustbrian
Collaborator

faustbrian commented Dec 4, 2018

No description provided.

vasild and others added some commits Dec 3, 2018

refactor(core-blockchain): remove unnecessary await (#1559)
transaction pool's flush() method is not async, no need to call it with await.
feat(core-api): allow block display via height in v2 API (#1626)
* feat(core-api): allow block display via height in v2 API

* fix(core-api): make sure the value we work with is a safe integer

@wafflebot wafflebot bot added the review label Dec 4, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Dec 4, 2018

Codecov Report

Merging #1628 into master will increase coverage by 0.12%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1628      +/-   ##
==========================================
+ Coverage   74.75%   74.87%   +0.12%     
==========================================
  Files         439      439              
  Lines        7894     7896       +2     
  Branches     1038     1039       +1     
==========================================
+ Hits         5901     5912      +11     
+ Misses       1770     1764       -6     
+ Partials      223      220       -3
Impacted Files Coverage Δ
packages/core-api/lib/versions/2/handlers/peers.js 61.76% <ø> (ø) ⬆️
packages/core-api/lib/repositories/blocks.js 88.09% <50%> (-1.91%) ⬇️
packages/core-transaction-pool/lib/interface.js 69.41% <60%> (ø) ⬆️
...p2p/lib/server/versions/internal/handlers/utils.js 86.66% <0%> (+6.66%) ⬆️
packages/core-forger/lib/manager.js 80.58% <0%> (+8.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4efbde7...e41269c. Read the comment docs.

@faustbrian faustbrian merged commit 6c1dc3e into master Dec 4, 2018

4 checks passed

ci/circleci: depcheck-lint Your tests passed on CircleCI!
Details
ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details

@wafflebot wafflebot bot removed the review label Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment