New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-deployer): map keys based on object keys instead of values #1630

merged 4 commits into from Dec 4, 2018


None yet
3 participants

Z-a-r-a-k-i commented Dec 4, 2018

…g core-deployer

Proposed changes

forEach function can only be called on an Array. Therefore it is required to extract an array of keys from values Object (by calling Object.keys(values)), to be able to call forEach on it and then set the config values.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

faustbrian and others added some commits Dec 3, 2018

Merge pull request #1558 from ArkEcosystem/develop
merge develop to master

This comment has been minimized.

codecov-io commented Dec 4, 2018

Codecov Report

Merging #1630 into master will increase coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1630     +/-   ##
+ Coverage   74.74%   74.84%   +0.1%     
  Files         439      439             
  Lines        7896     7896             
  Branches     1039     1039             
+ Hits         5902     5910      +8     
+ Misses       1771     1764      -7     
+ Partials      223      222      -1
Impacted Files Coverage Δ
packages/core-deployer/lib/utils.js 0% <0%> (ø) ⬆️
packages/core-forger/lib/manager.js 77.66% <0%> (+5.82%) ⬆️
...p2p/lib/server/versions/internal/handlers/utils.js 93.33% <0%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c1dc3e...3c9b6ed. Read the comment docs.

@faustbrian faustbrian changed the title from Fixed issue "TypeError: values.forEach is not a function" when runnin… to fix(core-deployer): map keys based on object keys instead of values Dec 4, 2018

@faustbrian faustbrian changed the base branch from master to develop Dec 4, 2018

@wafflebot wafflebot bot added the review label Dec 4, 2018

@faustbrian faustbrian merged commit a9d42af into ArkEcosystem:develop Dec 4, 2018

4 checks passed

ci/circleci: depcheck-lint Your tests passed on CircleCI!
ci/circleci: test-node10-0 Your tests passed on CircleCI!
ci/circleci: test-node10-1 Your tests passed on CircleCI!
ci/circleci: test-node10-2 Your tests passed on CircleCI!

@wafflebot wafflebot bot removed the review label Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment