New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove depcheck #1632

Merged
merged 6 commits into from Dec 4, 2018

Conversation

Projects
None yet
2 participants
@faustbrian
Collaborator

faustbrian commented Dec 4, 2018

Proposed changes

Everything this package does will be taken care of by TypeScript as builds will fail if any dependencies are missing or wrong.

Types of changes

  • Build (changes that affect the build system)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from supaiku0 Dec 4, 2018

@wafflebot wafflebot bot added the review label Dec 4, 2018

faustbrian added some commits Dec 4, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Dec 4, 2018

Codecov Report

Merging #1632 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1632   +/-   ##
========================================
  Coverage    74.87%   74.87%           
========================================
  Files          439      439           
  Lines         7896     7896           
  Branches      1039     1039           
========================================
  Hits          5912     5912           
  Misses        1764     1764           
  Partials       220      220

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6226bab...104a128. Read the comment docs.

@faustbrian faustbrian merged commit b7597ce into develop Dec 4, 2018

3 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details

@wafflebot wafflebot bot removed the review label Dec 4, 2018

@faustbrian faustbrian deleted the drop-depcheck branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment