New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-database-postgres): store executed migrations in the database #1648

Merged
merged 5 commits into from Dec 5, 2018

Conversation

Projects
None yet
2 participants
@faustbrian
Collaborator

faustbrian commented Dec 5, 2018

Proposed changes

A quick implementation of storing migrations in the database so we don't execute them more then once.

Will expand this later on to do some more checks as this implementation is very simple.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from supaiku0 Dec 5, 2018

@wafflebot wafflebot bot added the review label Dec 5, 2018

@faustbrian faustbrian changed the title from feat(core-database-postgres): store executed migrations in the database to feat(core-database-postgres): store executed migrations in the database Dec 5, 2018

faustbrian added some commits Dec 5, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Dec 5, 2018

Codecov Report

Merging #1648 into develop will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1648      +/-   ##
===========================================
+ Coverage    74.88%   74.94%   +0.05%     
===========================================
  Files          441      443       +2     
  Lines         7927     7945      +18     
  Branches      1044     1046       +2     
===========================================
+ Hits          5936     5954      +18     
  Misses        1768     1768              
  Partials       223      223
Impacted Files Coverage Δ
...ackages/core-database-postgres/lib/models/index.js 100% <ø> (ø) ⬆️
...s/core-database-postgres/lib/repositories/index.js 100% <ø> (ø) ⬆️
...ckages/core-database-postgres/lib/queries/index.js 100% <ø> (ø) ⬆️
...ges/core-database-postgres/lib/migrations/index.js 100% <ø> (ø) ⬆️
...ges/core-database-postgres/lib/models/migration.js 100% <100%> (ø)
...e-database-postgres/lib/repositories/migrations.js 100% <100%> (ø)
packages/core-database-postgres/lib/connection.js 78.44% <100%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d434e...5a5d002. Read the comment docs.

@faustbrian faustbrian merged commit b4e4d56 into develop Dec 5, 2018

3 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the idx branch Dec 5, 2018

@wafflebot wafflebot bot removed the review label Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment