New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update second signature tests #1665

Merged
merged 2 commits into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@supaiku0
Contributor

supaiku0 commented Dec 6, 2018

Proposed changes

Fixes failings tests due to recent changes, by using proper test fixtures. Also adds additional tests for second signature registrations.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@supaiku0 supaiku0 requested a review from faustbrian Dec 6, 2018

@wafflebot wafflebot bot added the review label Dec 6, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Dec 6, 2018

Codecov Report

Merging #1665 into develop will increase coverage by 9.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1665      +/-   ##
===========================================
+ Coverage    66.02%   75.09%   +9.06%     
===========================================
  Files          444      444              
  Lines         7961     7961              
  Branches      1037     1048      +11     
===========================================
+ Hits          5256     5978     +722     
+ Misses        2390     1763     -627     
+ Partials       315      220      -95
Impacted Files Coverage Δ
...ore-api/lib/versions/2/transformers/transaction.js 100% <ø> (ø) ⬆️
...ypto/lib/handlers/transactions/second-signature.js 100% <100%> (ø) ⬆️
packages/core-database/lib/wallet-manager.js 83.06% <0%> (+0.54%) ⬆️
packages/core-blockchain/lib/blockchain.js 75.82% <0%> (+1.42%) ⬆️
packages/core-container/lib/container.js 57.14% <0%> (+1.42%) ⬆️
packages/core-blockchain/lib/state-storage.js 88.4% <0%> (+1.44%) ⬆️
packages/core-container/lib/registrars/plugin.js 89.41% <0%> (+2.35%) ⬆️
packages/crypto/lib/models/block.js 74.67% <0%> (+2.57%) ⬆️
packages/core-database-postgres/lib/connection.js 78.44% <0%> (+2.58%) ⬆️
packages/crypto/lib/crypto/crypto.js 93.56% <0%> (+2.92%) ⬆️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6b917...c6c2270. Read the comment docs.

@faustbrian faustbrian merged commit 662c59f into ArkEcosystem:develop Dec 6, 2018

3 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details

@wafflebot wafflebot bot removed the review label Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment