Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(core-interfaces): initial implementation #1924
The gist of this PR is captured in the discussion I had with @faustbrian in the issue above.
So far, I've created/implemented interfaces for core-container, core-blockchain, core-logger, core-event-emitter, core-p2p, core-transaction-pool.
The stipulation with this new package is that, only interfaces of core modules and only interfaces/classes that are referenced across modules are added. If an interface/class doesn't have to be visible outside its module to be used, then it doesn't get added. This prevents bloating up of the core-interfaces module
Types of changes
Jan 2, 2019
@faustbrian I would like to move the
And after consolidation
out of blockchain.ts and into IContainer & Container respectively, also add a
A future refactor of the
Right now the container is basically the application object and knows about things it shouldn't be concerned with like what config/network we are going to use, our application version and if the application is shutting down or not.
Those kinda information should be stored in a