New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract jest matchers into its own package #1926

Merged
merged 2 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Jan 3, 2019

Proposed changes

Resolves #1907

Extracting the matchers into its own package allows the use of those matchers in other TS/JS projects without all the clutter that is specific to only core.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@wafflebot wafflebot bot added the review label Jan 3, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 3, 2019

Codecov Report

Merging #1926 into develop will decrease coverage by 0.19%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #1926     +/-   ##
==========================================
- Coverage    39.55%   39.35%   -0.2%     
==========================================
  Files          350      350             
  Lines         7622     7622             
  Branches      1156     1163      +7     
==========================================
- Hits          3015     3000     -15     
- Misses        4593     4607     +14     
- Partials        14       15      +1
Impacted Files Coverage Δ
.../core-jest-matchers/src/transactions/types/ipfs.ts 80% <ø> (ø)
...e-jest-matchers/src/blockchain/execute-on-entry.ts 75% <ø> (ø)
packages/core-jest-matchers/src/api/peer.ts 0% <ø> (ø)
packages/core-jest-matchers/src/api/block.ts 0% <ø> (ø)
...kages/core-jest-matchers/src/transactions/valid.ts 75% <ø> (ø)
...matchers/src/transactions/types/multi-signature.ts 80% <ø> (ø)
...kages/core-jest-matchers/src/models/transaction.ts 85.71% <ø> (ø)
...e-jest-matchers/src/transactions/types/transfer.ts 80% <ø> (ø)
packages/core-jest-matchers/src/models/delegate.ts 80% <ø> (ø)
...e-jest-matchers/src/transactions/types/delegate.ts 80% <ø> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bb3b6...cb3949b. Read the comment docs.

@faustbrian faustbrian requested a review from supaiku0 Jan 3, 2019

@faustbrian faustbrian merged commit b26ab9c into develop Jan 3, 2019

8 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-slow Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-slow Your tests passed on CircleCI!
Details

@wafflebot wafflebot bot removed the review label Jan 3, 2019

@faustbrian faustbrian deleted the feat/core-jest-matchers branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment