New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-api): return the transaction expiration time via node/configuration #1927

Merged
merged 2 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Jan 3, 2019

Proposed changes

Resolves #1899

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@wafflebot wafflebot bot added the review label Jan 3, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 3, 2019

Codecov Report

Merging #1927 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1927      +/-   ##
===========================================
- Coverage    39.55%   39.55%   -0.01%     
===========================================
  Files          350      350              
  Lines         7622     7623       +1     
  Branches      1156     1133      -23     
===========================================
  Hits          3015     3015              
- Misses        4593     4595       +2     
+ Partials        14       13       -1
Impacted Files Coverage Δ
...ackages/core-api/src/versions/2/node/controller.ts 0% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bb3b6...eff3bef. Read the comment docs.

@faustbrian faustbrian merged commit 18120a3 into develop Jan 3, 2019

0 of 8 checks passed

ci/circleci: test-node10-0 Your tests are queued behind your running builds
Details
ci/circleci: test-node10-1 Your tests are queued behind your running builds
Details
ci/circleci: test-node10-2 Your tests are queued behind your running builds
Details
ci/circleci: test-node10-slow Your tests are queued behind your running builds
Details
ci/circleci: test-node11-0 Your tests are queued behind your running builds
Details
ci/circleci: test-node11-1 Your tests are queued behind your running builds
Details
ci/circleci: test-node11-2 Your tests are queued behind your running builds
Details
ci/circleci: test-node11-slow Your tests are queued behind your running builds
Details

@faustbrian faustbrian deleted the feat/api-tx-age branch Jan 3, 2019

@wafflebot wafflebot bot removed the review label Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment