New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simpler CircleCI config generation script #1928

Merged
merged 3 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Jan 3, 2019

Proposed changes

Right now the config file is constantly regenerated because the files count changes over time but since we run the slow crypto tests now in a separate job there is no benefit to running tests in order of file count.

Types of changes

  • Other

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@wafflebot wafflebot bot added the review label Jan 3, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 3, 2019

Codecov Report

Merging #1928 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1928   +/-   ##
========================================
  Coverage    39.55%   39.55%           
========================================
  Files          350      350           
  Lines         7622     7622           
  Branches      1156     1150    -6     
========================================
  Hits          3015     3015           
  Misses        4593     4593           
  Partials        14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bb3b6...37700f0. Read the comment docs.

@faustbrian faustbrian merged commit 276b4e2 into develop Jan 3, 2019

0 of 8 checks passed

ci/circleci: test-node10-0 Your tests are queued behind your running builds
Details
ci/circleci: test-node10-1 Your tests are queued behind your running builds
Details
ci/circleci: test-node10-2 Your tests are queued behind your running builds
Details
ci/circleci: test-node10-slow Your tests are queued behind your running builds
Details
ci/circleci: test-node11-0 Your tests are queued behind your running builds
Details
ci/circleci: test-node11-1 Your tests are queued behind your running builds
Details
ci/circleci: test-node11-2 Your tests are queued behind your running builds
Details
ci/circleci: test-node11-slow Your tests are queued behind your running builds
Details

@wafflebot wafflebot bot removed the review label Jan 3, 2019

@faustbrian faustbrian deleted the chore/generation branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment