New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypto): only allow vendor fields for type 0 & type 6 #1931

Merged
merged 7 commits into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Jan 3, 2019

Proposed changes

Right now the serialisation and deserialisation assumes that every transaction type can have a vendor field which is not the case, at least I can't come up with any scenario right now why a second signature or vote would need a vendor field.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from supaiku0 Jan 3, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 3, 2019

Codecov Report

Merging #1931 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1931      +/-   ##
===========================================
+ Coverage    40.48%   40.52%   +0.03%     
===========================================
  Files          350      350              
  Lines         7564     7569       +5     
  Branches      1136     1129       -7     
===========================================
+ Hits          3062     3067       +5     
- Misses        4487     4488       +1     
+ Partials        15       14       -1
Impacted Files Coverage Δ
...ation/extensions/transactions/timelock-transfer.ts 100% <ø> (ø) ⬆️
...ion/rules/models/transactions/timelock-transfer.ts 0% <ø> (ø) ⬆️
packages/crypto/src/models/transaction.ts 81.48% <100%> (+0.43%) ⬆️
packages/core-logger-winston/src/formatter.ts 38.88% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06ab743...d991ca5. Read the comment docs.

@faustbrian faustbrian changed the title refactor(crypto): only allow vendor fields for type 1 & type 6 refactor(crypto): only allow vendor fields for type 0 & type 6 Jan 3, 2019

faustbrian added some commits Jan 3, 2019

@faustbrian faustbrian merged commit 86a4a2f into develop Jan 3, 2019

8 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-slow Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-slow Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the ref/vendor-field branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment