New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-transaction-pool): use distinct error codes for different fee problems #1938

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Jan 3, 2019

Proposed changes

Resolves a comment from #1937

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from supaiku0 Jan 3, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 3, 2019

Codecov Report

Merging #1938 into develop will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1938      +/-   ##
===========================================
- Coverage    40.49%   40.48%   -0.02%     
===========================================
  Files          350      350              
  Lines         7562     7564       +2     
  Branches      1123     1105      -18     
===========================================
  Hits          3062     3062              
- Misses        4486     4488       +2     
  Partials        14       14
Impacted Files Coverage Δ
packages/core-transaction-pool/src/guard.ts 87.87% <75%> (-1.82%) ⬇️
packages/core-logger-winston/src/formatter.ts 38.88% <0%> (ø) ⬆️
packages/core-test-utils/src/generators/wallets.ts 14.28% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13bc930...de467e5. Read the comment docs.

@vasild

vasild approved these changes Jan 3, 2019

@faustbrian faustbrian merged commit 06ab743 into develop Jan 3, 2019

8 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-slow Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-slow Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the ref/pool-guard branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment