New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: export core-api types #1948

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@paroxysm
Copy link
Contributor

paroxysm commented Jan 6, 2019

Proposed changes

Closes #1786

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@faustbrian faustbrian merged commit 9d223c8 into ArkEcosystem:develop Jan 7, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

JeremiGendron added a commit to JeremiGendron/core that referenced this pull request Jan 7, 2019

JeremiGendron added a commit to JeremiGendron/core that referenced this pull request Jan 7, 2019

@paroxysm paroxysm deleted the paroxysm:feat/export-core-api-types branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment