New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): use correct schemas #1954

Merged
merged 3 commits into from Jan 8, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Jan 8, 2019

Proposed changes

Was using incorrect schemas for some endpoints.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

faustbrian added some commits Jan 8, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 8, 2019

Codecov Report

Merging #1954 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1954      +/-   ##
===========================================
- Coverage    38.62%   38.61%   -0.01%     
===========================================
  Files          353      353              
  Lines         7747     7749       +2     
  Branches      1141     1137       -4     
===========================================
  Hits          2992     2992              
- Misses        4742     4743       +1     
- Partials        13       14       +1
Impacted Files Coverage Δ
packages/core-api/src/versions/2/wallets/routes.ts 0% <ø> (ø) ⬆️
...ckages/core-api/src/versions/2/delegates/schema.ts 0% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 38.88% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69421d7...d01a14e. Read the comment docs.

@supaiku0 supaiku0 merged commit 80e35a9 into develop Jan 8, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@supaiku0 supaiku0 deleted the fix/api-schema branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment