New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: guard modify tx after sign + update core-transaction-pool tests with unitnet network #1956

Merged
merged 4 commits into from Jan 9, 2019

Conversation

Projects
None yet
2 participants
@air1one
Copy link
Collaborator

air1one commented Jan 9, 2019

Proposed changes

Added tests to transaction-pool guard when trying to modify transaction fields after signing, then validate.

Also updated unitnet network (was missing some transactions to fill new wallets).

And updated all core-transaction-pool tests to use unitnet network.

Types of changes

  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@faustbrian faustbrian merged commit a6e98f0 into develop Jan 9, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the test/guard-modify-tx-after-sign branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment