New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): return the database timestamp instead of deserialised #1957

Merged
merged 5 commits into from Jan 9, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Jan 9, 2019

Proposed changes

The timestamp of the deserialised transaction was used instead of the timestamp from the database by which transactions are sorted.

The problem with that is that the timestamp gets overwritten when a transaction gets forged so the timestamp in the database and serialised transaction differ.

Resolves #1951

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian changed the title Fix/api timestamp fix(core-api): return the database timestamp instead of deserialised Jan 9, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 9, 2019

Codecov Report

Merging #1957 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1957   +/-   ##
========================================
  Coverage    38.61%   38.61%           
========================================
  Files          354      354           
  Lines         7762     7762           
  Branches      1137     1139    +2     
========================================
  Hits          2997     2997           
  Misses        4751     4751           
  Partials        14       14
Impacted Files Coverage Δ
...ore-api/src/versions/1/transactions/transformer.ts 0% <0%> (ø) ⬆️
packages/core-api/src/repositories/transactions.ts 0% <0%> (ø) ⬆️
...ore-api/src/versions/2/transactions/transformer.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e98f0...1441a56. Read the comment docs.

@dated dated referenced this pull request Jan 9, 2019

Merged

refactor: transaction filtering #542

5 of 5 tasks complete
@supaiku0
Copy link
Contributor

supaiku0 left a comment

Looks reasonable.

@supaiku0 supaiku0 merged commit dfa2ac0 into develop Jan 9, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@supaiku0 supaiku0 deleted the fix/api-timestamp branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment