New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(crypto): update handler tests to apply basic tests to all handlers #1958

Merged
merged 1 commit into from Jan 9, 2019

Conversation

Projects
None yet
2 participants
@air1one
Copy link
Collaborator

air1one commented Jan 9, 2019

Proposed changes

In crypto transaction handlers, we have one abstract handler which is extended for transfer, vote, etc handlers.

We have basic tests for this abstract handler, but these tests should also be done on each sub-handler. This was the 1st change for this PR.

Also added to these basic tests a "insufficient balance in wallet" test.

Types of changes

  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@faustbrian faustbrian changed the title test: update handler tests to apply basic tests to all handlers + new test test(crypto): update handler tests to apply basic tests to all handlers + new test Jan 9, 2019

@faustbrian faustbrian changed the title test(crypto): update handler tests to apply basic tests to all handlers + new test test(crypto): update handler tests to apply basic tests to all handlers Jan 9, 2019

@faustbrian faustbrian merged commit 9b26df4 into develop Jan 9, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the test/crypto-handlers branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment