New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-debugger-cli): replace commander.js with @oclif #2049

Merged
merged 6 commits into from Feb 1, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Feb 1, 2019

Proposed changes

Resolves #1929

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from supaiku0 Feb 1, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 1, 2019

@alexbarnsley @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #2049 into develop will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2049      +/-   ##
===========================================
+ Coverage    73.62%   73.69%   +0.06%     
===========================================
  Files          365      366       +1     
  Lines         8202     8223      +21     
  Branches      1165     1188      +23     
===========================================
+ Hits          6039     6060      +21     
  Misses        2131     2131              
  Partials        32       32
Impacted Files Coverage Δ
...es/core-debugger-cli/src/commands/verify-second.ts 100% <100%> (ø) ⬆️
packages/core-debugger-cli/src/commands/command.ts 100% <100%> (ø)
...ackages/core-debugger-cli/src/commands/identity.ts 100% <100%> (ø) ⬆️
packages/core-debugger-cli/src/commands/verify.ts 100% <100%> (ø) ⬆️
...ckages/core-debugger-cli/src/commands/serialize.ts 100% <100%> (ø) ⬆️
...ages/core-debugger-cli/src/commands/deserialize.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77b15a...052f039. Read the comment docs.

faustbrian added some commits Feb 1, 2019

@supaiku0 supaiku0 merged commit ef563b7 into develop Feb 1, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/oclif-debugger branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment