New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-snapshots-cli): replace commander.js with @oclif #2050

Merged
merged 8 commits into from Feb 1, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Feb 1, 2019

Proposed changes

Resolves #1933

A few blocks are commented out because the filename flag apparently never existed if you check https://github.com/ArkEcosystem/core/blob/develop/packages/core-snapshots-cli/src/index.ts.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from supaiku0 Feb 1, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 1, 2019

@alexbarnsley @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #2050 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2050   +/-   ##
========================================
  Coverage    73.62%   73.62%           
========================================
  Files          365      365           
  Lines         8202     8202           
  Branches      1197     1186   -11     
========================================
  Hits          6039     6039           
  Misses        2129     2129           
  Partials        34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0652c09...904af7f. Read the comment docs.

faustbrian added some commits Feb 1, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 1, 2019

@faustbrian The ci/circleci: test-node11-0 job is failing as of bc920040522818f0b9ec7379e95f1f084e155f1c. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@supaiku0 supaiku0 referenced this pull request Feb 1, 2019

Merged

docs: update snapshots usage #259

0 of 11 tasks complete

@faustbrian faustbrian merged commit d77b15a into develop Feb 1, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/oclif-snapshots branch Feb 1, 2019

vasild added a commit that referenced this pull request Feb 1, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into verify-…
…peer-state

* ArkEcosystem/core/develop:
  refactor(core-snapshots-cli): replace commander.js with @oclif (#2050)
  chore: ignore a few things for coverage
  docs: update changelog with pull request links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment