New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move genesisBlock to network config and remove extraneous config #2052

Merged
merged 8 commits into from Feb 2, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Feb 2, 2019

Proposed changes

Right now the genesis block is exposed to the user and stored in the config directory. This shouldn't be the case as the genesisBlock is specific to a network, not a user.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 2, 2019

@supaiku0 @air1one - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 2, 2019

@faustbrian The ci/circleci: test-node10-2 job is failing as of 0dff5a7a2136853a87f14fa3dbb82836aa08d4db. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

faustbrian added some commits Feb 2, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 2, 2019

Codecov Report

Merging #2052 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2052      +/-   ##
===========================================
+ Coverage     73.8%   73.81%   +<.01%     
===========================================
  Files          367      367              
  Lines         8258     8259       +1     
  Branches      1188     1165      -23     
===========================================
+ Hits          6095     6096       +1     
  Misses        2131     2131              
  Partials        32       32
Impacted Files Coverage Δ
packages/core-container/src/config/network.ts 82.35% <ø> (ø) ⬆️
packages/core-container/src/config/schema.ts 100% <ø> (ø) ⬆️
packages/crypto/src/managers/config.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e4aa6...0cc2f16. Read the comment docs.

@supaiku0 supaiku0 merged commit 9828c96 into develop Feb 2, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/crypto-config branch Feb 2, 2019

vasild added a commit that referenced this pull request Feb 4, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into verify-…
…peer-state

* ArkEcosystem/core/develop:
  chore: few upgrade script fixes (#2060)
  misc: add github templates for docs, security and support (#2059)
  fix: remove entries with double and single quotes during the upgrade
  fix: syntax error in upgrade script
  fix(crypto): disable multisig (#2057)
  chore: add bash fallback for ARK > CORE in upgrade script
  refactor: move genesisBlock to network config and remove extraneous config (#2052)
  chore: store development docker files in docker/development (#2053)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment