New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crypto): disable multisig #2057

Merged
merged 4 commits into from Feb 4, 2019

Conversation

Projects
None yet
5 participants
@supaiku0
Copy link
Contributor

supaiku0 commented Feb 4, 2019

Proposed changes

To be superseded by AIP18.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

supaiku0 added some commits Feb 3, 2019

misc: devnet exceptions
first batch: type 4
second batch: multi signed transactions

@supaiku0 supaiku0 requested a review from faustbrian Feb 4, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 4, 2019

@faustbrian @air1one - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 4, 2019

Codecov Report

Merging #2057 into develop will decrease coverage by 0.04%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2057      +/-   ##
===========================================
- Coverage    73.81%   73.76%   -0.05%     
===========================================
  Files          367      367              
  Lines         8259     8257       -2     
  Branches      1177     1176       -1     
===========================================
- Hits          6096     6091       -5     
- Misses        2131     2134       +3     
  Partials        32       32
Impacted Files Coverage Δ
...ckages/crypto/src/handlers/transactions/handler.ts 97.56% <0%> (-2.44%) ⬇️
packages/crypto/src/models/transaction.ts 100% <100%> (ø) ⬆️
...rypto/src/handlers/transactions/multi-signature.ts 90% <0%> (-10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a3a45b...7d24137. Read the comment docs.

@faustbrian faustbrian merged commit aac0e96 into ArkEcosystem:develop Feb 4, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

vasild added a commit that referenced this pull request Feb 4, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into verify-…
…peer-state

* ArkEcosystem/core/develop:
  chore: few upgrade script fixes (#2060)
  misc: add github templates for docs, security and support (#2059)
  fix: remove entries with double and single quotes during the upgrade
  fix: syntax error in upgrade script
  fix(crypto): disable multisig (#2057)
  chore: add bash fallback for ARK > CORE in upgrade script
  refactor: move genesisBlock to network config and remove extraneous config (#2052)
  chore: store development docker files in docker/development (#2053)
@n4ru

This comment has been minimized.

Copy link

n4ru commented Feb 4, 2019

Why? The ACF has plans to use multisig and there's no clear timeline for the addition of the new implemention. This would severely impede plans to remove dedicated escrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment