New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: core-blockchain coverage #2066

Merged
merged 19 commits into from Feb 6, 2019

Conversation

Projects
None yet
4 participants
@air1one
Copy link
Collaborator

air1one commented Feb 6, 2019

Proposed changes

Added tests to core-blockchain to get to 100% coverage (minus 1 line 馃槶 ).

Also slight refactor of state-machine.ts for getting a random number.

And also now between each circleci step, we reset the database (drop everything and re-create) so that we start each test step in a clean state.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 6, 2019

@faustbrian @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #2066 into develop will increase coverage by 2.54%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2066      +/-   ##
===========================================
+ Coverage    75.82%   78.37%   +2.54%     
===========================================
  Files          330      330              
  Lines         7698     7698              
  Branches      1069     1056      -13     
===========================================
+ Hits          5837     6033     +196     
+ Misses        1829     1634     -195     
+ Partials        32       31       -1
Impacted Files Coverage 螖
packages/core-blockchain/src/state-machine.ts 100% <100%> (+53.64%) 猬嗭笍
...ages/core-jest-matchers/src/blockchain/dispatch.ts 100% <100%> (+12.5%) 猬嗭笍
...database-postgres/src/repositories/transactions.ts 61.53% <0%> (-7.7%) 猬囷笍
.../core-database-postgres/src/repositories/blocks.ts 56.25% <0%> (-6.25%) 猬囷笍
packages/core-database-postgres/src/connection.ts 35.34% <0%> (-5.18%) 猬囷笍
...kchain/src/processor/handlers/unchained-handler.ts 100% <0%> (+4.25%) 猬嗭笍
packages/core-blockchain/src/queue/interface.ts 100% <0%> (+10%) 猬嗭笍
...s/core-blockchain/src/processor/block-processor.ts 100% <0%> (+11.9%) 猬嗭笍
...ackages/core-database-postgres/src/models/model.ts 50% <0%> (+12.5%) 猬嗭笍
packages/core-blockchain/src/state-storage.ts 100% <0%> (+13.51%) 猬嗭笍
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update cf74814...9a53684. Read the comment docs.

@faustbrian faustbrian merged commit 9a09fd4 into develop Feb 6, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the test/blockchain-coverage branch Feb 6, 2019

vasild added a commit that referenced this pull request Feb 6, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into verify-鈥
鈥eer-state

* ArkEcosystem/core/develop:
  test(core-blockchain): increase coverage (#2066)
  chore: ignore a few things for coverage
  chore(docker): mount database and log paths as volumes (#2064)
  chore: docker production set (#2063)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment